Files
ExcaliDash/e2e/tests/drag-and-drop.spec.ts
T
Zimeng Xiong 0476315322 0.2.1 Release (#32)
* feat(security): implement CSRF protection

* chore: clean up CSRF implementation

  - Remove unused generateCsrfToken export from security.ts
  - Remove redundant /csrf-token path check (GET already exempt)
  - Restore defineConfig wrapper in vitest.config.ts for type safety

* add K8S note in README, fix broken e2e

* feat/upload-bar (#30)

* feat/upload-bar: add a upload bar when user upload file, indicate the upload process

* feat/save-loading-status: add save status when click back button from editor

* fix: address PR review issues in upload and save features

- Replace deprecated substr() with substring() in UploadContext
- Fix broken error handling that checked stale task status
- Fix missing useEffect dependency in UploadStatus
- Fix CSS class conflict in progress bar styling
- Add error recovery for save state in Editor (reset on failure)
- Use .finally() instead of .then() to ensure refresh on upload failure
- Fix inconsistent indentation in UploadContext

* fix e2e tests

---------

Co-authored-by: Zimeng Xiong <zxzimeng@gmail.com>

* chore: pre-release v0.2.1-dev

* Update backend/src/security.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* fix filename/math random UUID generation

---------

Co-authored-by: AdrianAcala <adrianacala017@gmail.com>
Co-authored-by: adamant368 <60790941+Yiheng-Liu@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-01-14 11:25:27 -08:00

287 lines
9.8 KiB
TypeScript

import { test, expect } from "@playwright/test";
import * as path from "path";
import * as fs from "fs";
import {
createDrawing,
deleteDrawing,
listDrawings,
createCollection,
deleteCollection,
} from "./helpers/api";
/**
* E2E Tests for Drag and Drop functionality
*
* Tests the drag and drop feature mentioned in README:
* - Drag drawings into collections
* - Drag files to import drawings
* - Drag multiple selected drawings
*/
test.describe("Drag and Drop - Collections", () => {
let createdDrawingIds: string[] = [];
let createdCollectionIds: string[] = [];
test.afterEach(async ({ request }) => {
for (const id of createdDrawingIds) {
try {
await deleteDrawing(request, id);
} catch {
// Ignore cleanup errors
}
}
createdDrawingIds = [];
for (const id of createdCollectionIds) {
try {
await deleteCollection(request, id);
} catch {
// Ignore cleanup errors
}
}
createdCollectionIds = [];
});
test("should move drawing to collection via card menu", async ({ page, request }) => {
// Create a collection and a drawing
const collection = await createCollection(request, `DnD_Collection_${Date.now()}`);
createdCollectionIds.push(collection.id);
const drawing = await createDrawing(request, { name: `DnD_Drawing_${Date.now()}` });
createdDrawingIds.push(drawing.id);
await page.goto("/");
await page.waitForLoadState("networkidle");
// Find the drawing card
const card = page.locator(`#drawing-card-${drawing.id}`);
await card.waitFor();
await card.scrollIntoViewIfNeeded();
// Hover to reveal the collection picker
await card.hover();
// Click the collection picker button on the card
const collectionPicker = card.locator(`[data-testid="collection-picker-${drawing.id}"]`);
await collectionPicker.click();
// Select the collection from the dropdown
const collectionOption = page.locator(`[data-testid="collection-option-${collection.id}"]`);
await collectionOption.click();
// Verify the drawing was moved
await expect(collectionPicker).toContainText(collection.name);
// Navigate to the collection and verify drawing is there
await page.getByRole("navigation").getByRole("button", { name: collection.name }).click();
await page.waitForLoadState("networkidle");
await expect(card).toBeVisible();
});
test("should move drawing to Unorganized via card menu", async ({ page, request }) => {
// Create a collection and add a drawing to it
const collection = await createCollection(request, `UnorgTest_Collection_${Date.now()}`);
createdCollectionIds.push(collection.id);
const drawing = await createDrawing(request, {
name: `UnorgTest_Drawing_${Date.now()}`,
collectionId: collection.id
});
createdDrawingIds.push(drawing.id);
// Navigate to the collection
await page.goto(`/collections?id=${collection.id}`);
await page.waitForLoadState("networkidle");
const card = page.locator(`#drawing-card-${drawing.id}`);
await card.waitFor({ timeout: 10000 });
await card.hover();
// Open collection picker and select Unorganized
const collectionPicker = card.locator(`[data-testid="collection-picker-${drawing.id}"]`);
await collectionPicker.click();
// Wait for dropdown to appear
await page.waitForTimeout(300);
// Click Unorganized option
const unorganizedOption = page.locator(`[data-testid="collection-option-unorganized"]`);
await unorganizedOption.click();
// Wait for the update to complete
await page.waitForTimeout(500);
// Drawing should no longer be in the collection view
await expect(card).not.toBeVisible({ timeout: 5000 });
// Navigate to Unorganized and verify drawing is there
await page.getByRole("navigation").getByRole("button", { name: "Unorganized" }).click();
await page.waitForLoadState("networkidle");
await expect(page.locator(`#drawing-card-${drawing.id}`)).toBeVisible();
});
test("should move multiple selected drawings to collection via bulk menu", async ({ page, request }) => {
// Create a collection and multiple drawings
const collection = await createCollection(request, `BulkMove_Collection_${Date.now()}`);
createdCollectionIds.push(collection.id);
const prefix = `BulkMove_${Date.now()}`;
const [drawing1, drawing2] = await Promise.all([
createDrawing(request, { name: `${prefix}_A` }),
createDrawing(request, { name: `${prefix}_B` }),
]);
createdDrawingIds.push(drawing1.id, drawing2.id);
await page.goto("/");
await page.waitForLoadState("networkidle");
// Search for our test drawings
const searchInput = page.getByPlaceholder("Search drawings...");
await searchInput.fill(prefix);
await page.waitForTimeout(500);
// Select both drawings
const card1 = page.locator(`#drawing-card-${drawing1.id}`);
const card2 = page.locator(`#drawing-card-${drawing2.id}`);
await card1.hover();
const toggle1 = card1.locator(`[data-testid="select-drawing-${drawing1.id}"]`);
await toggle1.click();
await card2.hover();
const toggle2 = card2.locator(`[data-testid="select-drawing-${drawing2.id}"]`);
await toggle2.click();
// Click the bulk move button to open the menu
const moveButton = page.getByTitle("Move Selected");
await moveButton.click();
// Wait for the menu to appear and select the collection
// The menu shows collection names as buttons
await page.waitForTimeout(300);
const collectionOption = page.locator(`button:has-text("${collection.name}")`).last();
await collectionOption.click();
// Wait for the move to complete
await page.waitForTimeout(500);
// Navigate to the collection and verify both drawings are there
await page.getByRole("navigation").getByRole("button", { name: collection.name }).click();
await page.waitForLoadState("networkidle");
await expect(page.locator(`#drawing-card-${drawing1.id}`)).toBeVisible();
await expect(page.locator(`#drawing-card-${drawing2.id}`)).toBeVisible();
});
});
test.describe("Drag and Drop - File Import", () => {
let createdDrawingIds: string[] = [];
test.afterEach(async ({ request }) => {
// Clean up drawings created via import
const drawings = await listDrawings(request, { search: "ImportedDnD" });
for (const drawing of drawings) {
try {
await deleteDrawing(request, drawing.id);
} catch {
// Ignore cleanup errors
}
}
for (const id of createdDrawingIds) {
try {
await deleteDrawing(request, id);
} catch {
// Ignore cleanup errors
}
}
createdDrawingIds = [];
});
test("should show drop zone overlay when dragging files", async ({ page }) => {
// Note: Simulating drag events with files is unreliable in Playwright
// because the DataTransfer API has security restrictions.
// This test verifies the drop zone UI exists and can be triggered.
await page.goto("/");
await page.waitForLoadState("networkidle");
// Verify the dashboard is loaded
await expect(page.getByPlaceholder("Search drawings...")).toBeVisible();
// Try to trigger drag event - this may not work in all browsers
// due to security restrictions on DataTransfer
const triggered = await page.evaluate(() => {
try {
const dt = new DataTransfer();
dt.items.add(new File(['test'], 'test.excalidraw', { type: 'application/json' }));
const event = new DragEvent('dragenter', {
bubbles: true,
cancelable: true,
dataTransfer: dt,
});
// Find the main content area and dispatch the event
const main = document.querySelector('main');
if (main) {
main.dispatchEvent(event);
return true;
}
return false;
} catch (e) {
console.error('Failed to simulate drag event:', e);
return false;
}
});
if (triggered) {
// Check that the drop zone overlay is shown
const dropZone = page.getByText("Drop files to import");
const isVisible = await dropZone.isVisible().catch(() => false);
if (isVisible) {
await expect(dropZone).toBeVisible();
} else {
// If drag simulation doesn't work, verify the import button exists as fallback
await expect(page.locator("#dashboard-import")).toBeAttached();
}
} else {
// If drag simulation doesn't work, verify the import button exists as fallback
await expect(page.locator("#dashboard-import")).toBeAttached();
}
});
test("should import excalidraw file via file input", async ({ page }, testInfo) => {
await page.goto("/");
await page.waitForLoadState("networkidle");
// Resolve fixture relative to project test directory to avoid env differences
const fixturePath = path.join(testInfo.project.testDir, "..", "fixtures", "small-image.excalidraw");
// Fail fast if the fixture is missing instead of skipping the test
expect(fs.existsSync(fixturePath)).toBeTruthy();
// Click import button to open file dialog
const importButton = page.getByRole("button", { name: /Import/i });
await importButton.click();
// Find the hidden file input and upload the file
const fileInput = page.locator("#dashboard-import");
await fileInput.setInputFiles(fixturePath);
// Wait for upload to complete - the UploadStatus component shows "Done" when finished
await expect(page.getByText("Uploads (Done)")).toBeVisible({ timeout: 10000 });
// Search for the imported drawing (it uses the filename as name)
await page.getByPlaceholder("Search drawings...").fill("small-image");
await page.waitForTimeout(500);
// Verify at least one drawing was imported
const importedCards = page.locator("[id^='drawing-card-']");
await expect(importedCards.first()).toBeVisible();
});
});