tommy commented on pull request blueplum/apidoc#4 2026-01-29 17:39:42 +00:00
WIP: Tracking PR for initial parser

File: src/apidoc_parser/src/lib.rs:27 (important)

When a // comment is not an apidoc comment, you continue without advancing to end-of-line. This leaves the cursor in the middle of the…

tommy suggested changes for blueplum/apidoc#4 2026-01-29 17:39:41 +00:00
WIP: Tracking PR for initial parser

See summary comment above for details.

tommy commented on pull request blueplum/apidoc#4 2026-01-29 17:39:41 +00:00
WIP: Tracking PR for initial parser

File: src/apidoc_parser/src/lib.rs:17 (bug)

The loop advances the cursor before inspecting slice, which skips the very first character of the file. As a result, a comment that starts at…

tommy commented on pull request blueplum/apidoc#4 2026-01-29 17:39:16 +00:00
WIP: Tracking PR for initial parser

Automated review in progress

  • Fetching PR data and diff
  • Reviewing files
  • Posting summary and file comments

I'll update this comment when the review is complete.