Compare commits

..

2 Commits

Author SHA1 Message Date
Zimeng Xiong bea26a3abd fix: support both legacy and current currentItemRoundness formats
Add union type to accept both the old object format {type, value} and
the new enum format for backwards compatibility with existing drawings.
2026-01-20 09:39:11 -08:00
Sushil Kumar a8615d9087 pass rest of appState in put request 2026-01-18 02:07:54 +05:30
4 changed files with 27 additions and 106 deletions
-44
View File
@@ -1,44 +0,0 @@
name: Claude Code Review
on:
pull_request:
types: [opened, synchronize, ready_for_review, reopened]
# Optional: Only run on specific file changes
# paths:
# - "src/**/*.ts"
# - "src/**/*.tsx"
# - "src/**/*.js"
# - "src/**/*.jsx"
jobs:
claude-review:
# Optional: Filter by PR author
# if: |
# github.event.pull_request.user.login == 'external-contributor' ||
# github.event.pull_request.user.login == 'new-developer' ||
# github.event.pull_request.author_association == 'FIRST_TIME_CONTRIBUTOR'
runs-on: ubuntu-latest
permissions:
contents: read
pull-requests: read
issues: read
id-token: write
steps:
- name: Checkout repository
uses: actions/checkout@v4
with:
fetch-depth: 1
- name: Run Claude Code Review
id: claude-review
uses: anthropics/claude-code-action@v1
with:
claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
plugin_marketplaces: 'https://github.com/anthropics/claude-code.git'
plugins: 'code-review@claude-code-plugins'
prompt: '/code-review:code-review ${{ github.repository }}/pull/${{ github.event.pull_request.number }}'
# See https://github.com/anthropics/claude-code-action/blob/main/docs/usage.md
# or https://code.claude.com/docs/en/cli-reference for available options
-50
View File
@@ -1,50 +0,0 @@
name: Claude Code
on:
issue_comment:
types: [created]
pull_request_review_comment:
types: [created]
issues:
types: [opened, assigned]
pull_request_review:
types: [submitted]
jobs:
claude:
if: |
(github.event_name == 'issue_comment' && contains(github.event.comment.body, '@claude')) ||
(github.event_name == 'pull_request_review_comment' && contains(github.event.comment.body, '@claude')) ||
(github.event_name == 'pull_request_review' && contains(github.event.review.body, '@claude')) ||
(github.event_name == 'issues' && (contains(github.event.issue.body, '@claude') || contains(github.event.issue.title, '@claude')))
runs-on: ubuntu-latest
permissions:
contents: read
pull-requests: read
issues: read
id-token: write
actions: read # Required for Claude to read CI results on PRs
steps:
- name: Checkout repository
uses: actions/checkout@v4
with:
fetch-depth: 1
- name: Run Claude Code
id: claude
uses: anthropics/claude-code-action@v1
with:
claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
# This is an optional setting that allows Claude to read CI results on PRs
additional_permissions: |
actions: read
# Optional: Give a custom prompt to Claude. If this is not specified, Claude will perform the instructions specified in the comment that tagged it.
# prompt: 'Update the pull request description to include a summary of changes.'
# Optional: Add claude_args to customize behavior and configuration
# See https://github.com/anthropics/claude-code-action/blob/main/docs/usage.md
# or https://code.claude.com/docs/en/cli-reference for available options
# claude_args: '--allowed-tools Bash(gh pr:*)'
+26 -12
View File
@@ -30,7 +30,9 @@ let activeConfig: SecurityConfig = { ...defaultConfig };
* Configure security settings * Configure security settings
* @param config Partial configuration to merge with defaults * @param config Partial configuration to merge with defaults
*/ */
export const configureSecuritySettings = (config: Partial<SecurityConfig>): void => { export const configureSecuritySettings = (
config: Partial<SecurityConfig>
): void => {
activeConfig = { ...activeConfig, ...config }; activeConfig = { ...activeConfig, ...config };
}; };
@@ -318,10 +320,13 @@ export const appStateSchema = z
.optional() .optional()
.nullable(), .nullable(),
currentItemRoundness: z currentItemRoundness: z
.object({ .union([
type: z.enum(["round", "sharp"]), z.enum(["sharp", "round"]),
value: z.number().finite().min(0).max(1), z.object({
}) type: z.enum(["round", "sharp"]),
value: z.number().finite().min(0).max(1),
}),
])
.optional() .optional()
.nullable(), .nullable(),
currentItemFontSize: z currentItemFontSize: z
@@ -427,10 +432,19 @@ export const sanitizeDrawingData = (data: {
]; ];
// Dangerous URL protocols to block entirely // Dangerous URL protocols to block entirely
const dangerousProtocols = [/^javascript:/i, /^vbscript:/i, /^data:text\/html/i]; const dangerousProtocols = [
/^javascript:/i,
/^vbscript:/i,
/^data:text\/html/i,
];
// Suspicious patterns for security validation within data URLs // Suspicious patterns for security validation within data URLs
const suspiciousPatterns = [/<script/i, /javascript:/i, /on\w+\s*=/i, /<iframe/i]; const suspiciousPatterns = [
/<script/i,
/javascript:/i,
/on\w+\s*=/i,
/<iframe/i,
];
// Maximum size for dataURL (configurable, default 10MB to prevent DoS) // Maximum size for dataURL (configurable, default 10MB to prevent DoS)
const MAX_DATAURL_SIZE = activeConfig.maxDataUrlSize; const MAX_DATAURL_SIZE = activeConfig.maxDataUrlSize;
@@ -448,8 +462,8 @@ export const sanitizeDrawingData = (data: {
const normalizedValue = value.toLowerCase(); const normalizedValue = value.toLowerCase();
// First, check for dangerous protocols - block these entirely // First, check for dangerous protocols - block these entirely
const hasDangerousProtocol = dangerousProtocols.some((pattern) => const hasDangerousProtocol = dangerousProtocols.some(
pattern.test(value) (pattern) => pattern.test(value)
); );
if (hasDangerousProtocol) { if (hasDangerousProtocol) {
@@ -465,8 +479,8 @@ export const sanitizeDrawingData = (data: {
if (isSafeImageType) { if (isSafeImageType) {
// Check for suspicious content and size limits // Check for suspicious content and size limits
const hasSuspiciousContent = suspiciousPatterns.some((pattern) => const hasSuspiciousContent = suspiciousPatterns.some(
pattern.test(value) (pattern) => pattern.test(value)
); );
const isTooLarge = value.length > MAX_DATAURL_SIZE; const isTooLarge = value.length > MAX_DATAURL_SIZE;
@@ -570,7 +584,7 @@ const getCsrfSecret = (): Buffer => {
const envLabel = process.env.NODE_ENV ? ` (${process.env.NODE_ENV})` : ""; const envLabel = process.env.NODE_ENV ? ` (${process.env.NODE_ENV})` : "";
console.warn( console.warn(
`[security] CSRF_SECRET is not set${envLabel}. Using an ephemeral per-process secret. ` + `[security] CSRF_SECRET is not set${envLabel}. Using an ephemeral per-process secret. ` +
"For horizontal scaling (k8s), set CSRF_SECRET to the same value on all instances." "For horizontal scaling (k8s), set CSRF_SECRET to the same value on all instances."
); );
return cachedCsrfSecret; return cachedCsrfSecret;
}; };
+1
View File
@@ -301,6 +301,7 @@ export const Editor: React.FC = () => {
try { try {
const persistableAppState = { const persistableAppState = {
...appState,
viewBackgroundColor: appState?.viewBackgroundColor || '#ffffff', viewBackgroundColor: appState?.viewBackgroundColor || '#ffffff',
gridSize: appState?.gridSize || null, gridSize: appState?.gridSize || null,
}; };